-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #21378 - Add CSV export on tasks index #292
Conversation
@@ -1,17 +1,7 @@ | |||
module ForemanTasks | |||
module TasksHelper | |||
def format_task_input(task, include_action = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include_action is never set to false, removed it completely.
644eca3
to
b661ce3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fond of having yet another csv output format, but I guess it is better suited for the use case described in the issue than the one done by the export_tasks rake task.
It works as expected and the tests are green, ACK.
Needs rebase |
@iNecas thanks, rebased. |
@iNecas @adamruzicka ping? |
@tbrisker thanks and sorry for the delay |
No description provided.