Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21378 - Add CSV export on tasks index #292

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

tbrisker
Copy link
Member

No description provided.

@@ -1,17 +1,7 @@
module ForemanTasks
module TasksHelper
def format_task_input(task, include_action = false)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include_action is never set to false, removed it completely.

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fond of having yet another csv output format, but I guess it is better suited for the use case described in the issue than the one done by the export_tasks rake task.

It works as expected and the tests are green, ACK.

@iNecas
Copy link
Member

iNecas commented Oct 31, 2017

Needs rebase

@tbrisker
Copy link
Member Author

tbrisker commented Nov 5, 2017

@iNecas thanks, rebased.

@tbrisker
Copy link
Member Author

@iNecas @adamruzicka ping?

@adamruzicka adamruzicka merged commit 2060119 into theforeman:master Nov 13, 2017
@adamruzicka
Copy link
Contributor

@tbrisker thanks and sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants