Skip to content
Commits on Apr 29, 2016
  1. @domcleal @dLobatog
Commits on Apr 28, 2016
  1. @orrabin @dLobatog
  2. @timogoebel @dLobatog
  3. @tbrisker @dLobatog

    Fixes #14679 - Fix tabbing of puppet CA in proxy

    tbrisker committed with dLobatog Apr 17, 2016
    The links were missing the `data-toggle="tab"` attribute, causing the
    tabbing to break when using under katello.
Commits on Apr 27, 2016
  1. @ares @iNecas
  2. @tbrisker @dLobatog

    Fixes #14730 - Only search host proxies explicitly

    tbrisker committed with dLobatog Apr 26, 2016
    When searching hosts with free text in a taxonomy scope, if the taxonomy
    has "all smart proxies" associated, it leads to scoped search generating
    an incorrect scope which causes an invalid query:
    `SELECT smart_proxies.id FROM "smart_proxies" "puppet_ca_proxies_hosts"`
    Making the puppet_ca search only explicitly prevents this at the cost of
    not allowing to search by puppet_ca using free text. I believe this is a
    reasonable tradeoff as I did not find a simpler way to handle this (might
    require some deep tweeking in scoped search).
    To maintain consistency I also made the puppetmaster search explicit
    only.
  3. @orrabin @dLobatog
  4. @ares @dLobatog
Commits on Apr 22, 2016
  1. @domcleal @dLobatog

    fixes #14742 - retrieve template kind labels from plugin regs

    domcleal committed with dLobatog Apr 21, 2016
    Ensures plugin kinds registered in class variables aren't lost when the
    TemplateKind class is reloaded.
  2. @xprazak2 @dLobatog
  3. @ares @dLobatog

    Fixes #14769 - avoid template comments because of deface

    ares committed with dLobatog Apr 22, 2016
    After many hours spent on debugging I realized that the issue is that
    when action view compiles the template, some lines are concatenated
    together just split by ";". This becomes problem when ERB tag contained
    commentary symbol #. The reason is that when deface override is applied
    it first converts the template to tree using Nokogiri (see Parser.convert).
    
    This returns different results on different versions of underlying library.
    I didn't try to compile different versions but with libxml2-2.7.6-20.el6.x86_64 and
    libxslt-1.1.26-2.el6_3.1.x86_64 it does not wrap the silent erb tag with
    "\n" so as a result, this tag ends up on the same line as previous one.
    The same nokogiri but on newer lib versions
    (libxml2-2.9.1-5.el7_1.2.x86_64, libxslt-1.1.28-5.el7.x86_64) wrapped
    it.
Commits on Apr 21, 2016
  1. @shlomizadok @dLobatog
  2. @domcleal @dLobatog

    fixes #14741 - translate template kind string, not object

    domcleal committed with dLobatog Apr 21, 2016
    Also convert translation keys to strings in debug mode to prevent
    concatenation errors.
  3. @domcleal @dLobatog

    refs #14395 - change user-friendly template kind names

    domcleal committed with dLobatog Apr 21, 2016
    - PXELinux/PXEGrub to one word to match project names
    - change "Provision" to "Provisioning" to read better
    - change to sentence case to better match app
  4. @shlomizadok @tbrisker
Commits on Apr 20, 2016
  1. @domcleal

    fixes #13244 - update Rails to 4.2.6

    domcleal committed Jan 15, 2016
    - Add responders gem to support class-level respond_to usage
        - http://edgeguides.rubyonrails.org/4_2_release_notes.html#respond-with-class-level-respond-to
    - Replace foreigner with native Rails 4.2 FK support
        - uses a patch from Rails 5 to support Foreigner's
          `foreign_key_exists?` helper for full compatibility
        - `foreign_keys` should be avoided in favour of the higher level
          methods as it throws a NotImplementedError on sqlite3
    - Update DB adapter versions to match ActiveRecord
    - Enable exceptions from after_commit handlers to detect more errors
    - Change deprecated application config settings
    - Remove test:lib chaining on rake test task
        - 4.2 runs lib tasks automatically now, as test:run is redefined
          to all _test files within test/ rather than units+functionals.
          The task is still needed for the jenkins:* tasks.
    - Fix deprecation of mailer #deliver method, change to #deliver_now
    - Change CSRF test to use generated, not static tokens
        - 4.2 changes CSRF tokens to be different on every request and
          validated against the session, so use its generator to test the
          controller behaviour instead of hardcoding tokens.
    - Change test execution order to random
  2. @domcleal @tbrisker

    refs #14691 - user editing self should not change User.current

    domcleal committed with tbrisker Apr 19, 2016
    Rather than changing the behaviour of #to_label to return persisted
    data, the User.current object should not be modified with unsaved data
    from the form submission or API update.
    
    User.current is used for authz as well as for display purposes, so
    shouldn't be changed. Parameter filtering protects privilege escalation
    in this case.
  3. @xprazak2 @tbrisker
Commits on Apr 19, 2016
  1. @timogoebel @dLobatog
  2. @shlomizadok @dLobatog
  3. @shlomizadok @dLobatog
  4. @domcleal
Commits on Apr 18, 2016
  1. @tbrisker @dLobatog
  2. @akofink @dLobatog
  3. @dLobatog @tbrisker

    Fixes #9584 - User email address length can be longer than 60

    dLobatog committed with tbrisker Apr 14, 2016
    As far as I know, there's no need for this artificial limitation.
Commits on Apr 14, 2016
  1. @tbrisker @dLobatog

    Fixes #14636 - correctly search puppet class on host form

    tbrisker committed with dLobatog Apr 14, 2016
    Searching for puppet classes that were ellipsized did not work as
    expected on the host edit form. This was due to the search looking only
    in the span content which was truncated and did not contain the entire
    puppet class name. Also, cleaned up the js code to be clearer and more
    efficiant.
  2. @xprazak2 @dLobatog

    Fixes #6167 - 'Deployed on' dropdown in hosts/new form disabled until…

    xprazak2 committed with dLobatog Mar 9, 2016
    … ajax on hostgroup_changed is resolved
  3. @ares @dLobatog
  4. @ares @dLobatog
  5. @ohadlevy @tbrisker

    fixes #14640 - add missing whitespace to template text

    ohadlevy committed with tbrisker Apr 14, 2016
    provisioning template association text was missing whitespaces.
Commits on Apr 13, 2016
  1. @ares @iNecas
  2. @tbrisker @dLobatog

    Fixes #14563 - Improve dashboard layout

    tbrisker committed with dLobatog Apr 12, 2016
    The css used for calculating the dashboard layout is overcomplicated and
    does not allow for more then 8 rows of widgets without breaking.
    This PR cleans up useless code, allows up to 30 rows to be correctly
    displayed, and displays widgets that are being dragged instead of only
    showing their shadows.
Commits on Apr 12, 2016
  1. @orrabin @dLobatog
  2. @lzap @dLobatog
  3. @tbrisker @dLobatog

    Fixes #14566 - remove show_console_action function

    tbrisker committed with dLobatog Apr 12, 2016
    The `show_console_action` function is just a trenary operator, no sense
    making this a function. This also causes the link to be generated even
    if it is not needed, as it is passed to the function as a parameter.
Something went wrong with that request. Please try again.