New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #4581 Implement available_networks API for VMware #1277

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@gpetras

gpetras commented Mar 7, 2014

Implemented the available_networks, available_clusters, and available_storage_domains for VMware compute resources.The API for this was initially added in #4222.

@domcleal

This comment has been minimized.

Show comment
Hide comment
@domcleal

domcleal Mar 7, 2014

Contributor

[test]

Contributor

domcleal commented Mar 7, 2014

[test]

@domcleal

This comment has been minimized.

Show comment
Hide comment
@domcleal

domcleal Mar 7, 2014

Contributor

Mostly looks good, thanks. The one thing I can't see working is the use of cluster_id for listing networks. Fog only supports filtering by accessible or datacenter. Does this patch make sense to you - domcleal@c7e856f? I've changed available_networks to work as a top level API call so cluster_id isn't required for VMware but is for oVirt.

If so, I'll merge with those combined.

Contributor

domcleal commented Mar 7, 2014

Mostly looks good, thanks. The one thing I can't see working is the use of cluster_id for listing networks. Fog only supports filtering by accessible or datacenter. Does this patch make sense to you - domcleal@c7e856f? I've changed available_networks to work as a top level API call so cluster_id isn't required for VMware but is for oVirt.

If so, I'll merge with those combined.

@gpetras

This comment has been minimized.

Show comment
Hide comment
@gpetras

gpetras Mar 7, 2014

I did notice that the networks don't really filter at the cluster level. Having the cluster_id optional makes more sense. I applied your patch and it works against vSphere.

Thanks for your help!

Greg

gpetras commented Mar 7, 2014

I did notice that the networks don't really filter at the cluster level. Having the cluster_id optional makes more sense. I applied your patch and it works against vSphere.

Thanks for your help!

Greg

@domcleal

This comment has been minimized.

Show comment
Hide comment
@domcleal

domcleal Mar 7, 2014

Contributor

Merged as e4d8817 for Foreman 1.5.0, thanks @gpetras!

Contributor

domcleal commented Mar 7, 2014

Merged as e4d8817 for Foreman 1.5.0, thanks @gpetras!

@domcleal domcleal closed this Mar 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment