Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #4679 - Downcase FQDN to match expected SSL certs casing #1330

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@anyaelise
Copy link
Contributor

commented Mar 26, 2014

Downcases the fqdn in order to match the expected casing of the SSL certs
generated by Puppet.

fixes #4679
Downcases the fqdn in order to match the expected casing of the SSL certs
generated by Puppet.

@dLobatog dLobatog changed the title fixes #4679 fixes #4679 - Downcase FQDN to match expected SSL certs casing Mar 26, 2014

@dLobatog

This comment has been minimized.

Copy link
Member

commented Mar 26, 2014

Good one, thanks for finding this bug!

Maybe I'm asking for too much but could you point to the code in Puppet that generates the SSL certs, to make sure they always are created in lowercase?

FQDNs are case insensitive from my 5 min investigation and fiddling with /etc/hosts, so it's not an issue if they generate always certs with the fqdn in lowercase, although it's not what the GNU suite does...

@anyaelise

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2014

Okay, I'll look for the Puppet code. When I first talked to Dominic about
the issue, he suggested that Puppet couldn't really be changed, which is
why I ended up changing pretty much everything else... but I didn't look at
Puppet myself, so I'll do that.

On Wed, Mar 26, 2014 at 7:55 PM, Daniel Lobato García <
notifications@github.com> wrote:

Good one, thanks for finding this bug!

Maybe I'm asking for too much but could you point to the code in Puppet
that generates the SSL certs, to make sure they always are created in
lowercase?

FQDNs are case insensitive from my 5 min investigation and fiddling with
/etc/hosts, so it's not an issue if they generate always certs with the
fqdn in lowercase, although it's not what the GNU suite does...

Reply to this email directly or view it on GitHubhttps://github.com//pull/1330#issuecomment-38755093
.

@dLobatog

This comment has been minimized.

Copy link
Member

commented Mar 27, 2014

Merged as 0b2e3dc , thanks @anyaelise ! I'll make a note on the OPW application you've successfully submitted a contribution.

@dLobatog dLobatog closed this Mar 27, 2014

@dLobatog dLobatog referenced this pull request Mar 27, 2014

Closed

Fix #1 for Bug #4679 #171

@anyaelise

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2014

Excellent, thanks @elobato! And thanks as well @domcleal. It was a pleasure
working with you guys.

On Thu, Mar 27, 2014 at 6:54 AM, Daniel Lobato García <
notifications@github.com> wrote:

Closed #1330 #1330.

Reply to this email directly or view it on GitHubhttps://github.com//pull/1330
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.