Join GitHub today
Fixes #6768 - Hammer set-parameter does not work #1620
I tested it and it works well. My only concern is that all tests are exactly the same except for one word (host2, group2, etc..) and the new fixtures. Could you refactor them to avoid the code duplication and the new fixtures (by creating the parameters 'manually')?
@mbacovsky, commit messages should accurately describe what functionality they add. The point is that the git logs should be readable, and a reader should be able to get a feel for what each commit does.
In this case, if in 6 months we had an issue with scoped search on parameters, and went looking for related commits, a reader might skip this one entirely, as it doesn't mention scoped search at all. I would expect to see something like "Fixes #6768 - Add scoped search to parameters model and controller".
It's not worth updating this one, since it's already been merged, but we're merging too many things with unclear/misleading messages at the moment, and yours was the first one I happened to see today :P