New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #6538 - User group vs usergroup name consistency #1710
Conversation
[test] |
1 similar comment
[test] |
What the devil?
Is this my fault? |
@ripcurld00d it's not your'e fault all of the tests failed. |
@orrabin i see :) thanks. |
There's a "Usergroup" on the first form tab, stored in app/views/usergroups/_form.html.erb. |
Yes, you're right. I've also found some in views/usergroups/index.html.erb. |
I am not sure what |
[test] |
Don't change the s_() calls, what happens in these is that s_() returns the section after the | but translated - users will never see the first part. The "Usergroup" in those refers to the table name, which isn't changing, so just keep them as-is. |
Uh huh. OK. |
[test] |
merged as f45717f. Thanks @ripcurld00d ! |
I haven't seen any inconsistency in the app/view/*. However, I have changed to user group in app/controllers/api/v1/usergroups_controller.rb and app/models/auth_sources/auth_source_ldap.rb.