Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8830 - Allow two-pane to work on show #2048

Closed
wants to merge 1 commit into from

Conversation

orrabin
Copy link
Member

@orrabin orrabin commented Jan 5, 2015

No description provided.

@@ -7,7 +7,7 @@ $.fn.tab = function ( option ) {
}
}

$(document).on('click', ".table-two-pane td a[href$='edit']", function(e) {
$(document).on('click', ".table-two-pane td[class$='display-two-pane'] a", function(e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not ".table-two-pane .display-two-pane a"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftovers - at first it was called two-pane and other elements also had a class with the same name
I'll change it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use td.display-two-pane as well if you only want the tds with that class, [class$=...] lookups are much more expensive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a real pain, because this is an "on click" handler, therefore we are not filtering many elements. Just one or few per page.

@lzap
Copy link
Member

lzap commented Jan 15, 2015

@orrabin I still see the following occurances:

app/views/usergroups/_form.html.erb
24:        <table class="table table-bordered table-striped table-two-pane">

app/views/compute_resources/show.html.erb
61:    <table class="table table-bordered table-striped table-two-pane">

app/views/compute_profiles/show.html.erb
11:<table class="table table-bordered table-striped table-two-pane">

@lzap
Copy link
Member

lzap commented Jan 15, 2015

Disregard my previous comment, there are no links in there. I've checked Compute Profiles and two-pane does work there.

@lzap
Copy link
Member

lzap commented Jan 15, 2015

Thanks merged as 4027986.

@lzap lzap closed this Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants