Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8861 - Lengthy organization or location names showed in tooltip #2082

Closed
wants to merge 1 commit into from

Conversation

orrabin
Copy link
Member

@orrabin orrabin commented Jan 14, 2015

No description provided.

@@ -69,7 +69,7 @@ function onContentLoad(){

//set the tooltips
$('a[rel="popover"]').popover({html: true});
$('[rel="twipsy"]').tooltip();
$('[rel="twipsy"]').tooltip({ container: 'body' });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added since tooltips inside the org/location dropdowns where limited to the size of the dropdown and couldn't show the full title.
The problem is it affects all tooltips so better solutions are welcome.

@domcleal
Copy link
Contributor

"Location" typo in commit message.

@orrabin orrabin changed the title Fixes #8861 - Lengthy organization or localtion names showed in tooltip Fixes #8861 - Lengthy organization or location names showed in tooltip Jan 14, 2015
@orrabin
Copy link
Member Author

orrabin commented Jan 14, 2015

[test]

@orrabin
Copy link
Member Author

orrabin commented Jan 15, 2015

Tests should pass after: Katello/katello#4937 is merged

@dLobatog
Copy link
Member

@orrabin This will need some changes after this 2aa77d7 was merged right?

👍 from my side after it's in Katello

cc @ehelms

@orrabin
Copy link
Member Author

orrabin commented Jan 26, 2015

@elobato yes I'll rebase and change.
Katello has some problems with this, some of the views are broken since layout_helper in foreman and katello override each others methods.
I need to fix the views or add the helper method to layout_helper in katello and not use the one from foreman.

@ohadlevy
Copy link
Member

@orrabin can you rebase please? @tbrisker can you review? thanks!

@orrabin
Copy link
Member Author

orrabin commented Apr 20, 2015

@ohadlevy I rebased but tests will still fail until the katello PR is merged

@orrabin
Copy link
Member Author

orrabin commented Apr 21, 2015

[test] since katello PR was merged

@dLobatog
Copy link
Member

Merged as ae0d599, thanks @orrabin !

@dLobatog dLobatog closed this Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants