Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2948 - added sp_* host attributes to safe mode #2102

Closed
wants to merge 1 commit into from

Conversation

lzap
Copy link
Member

@lzap lzap commented Jan 22, 2015

Also few related changes:

  • added facts alias for facts_hash
  • exported facts attribute via safemode
  • removed extra attribute (was there twice: location)

I would like to backport this into 1.7 for Discovery 2.0.

@dLobatog
Copy link
Member

👍 , I will add these (and remove the duplicated location) to the HostJail test on merge. 3..2..1 💣

@dLobatog
Copy link
Member

Merged as 13d9564, thanks @lzap!

I've added these methods to the jail test, although in a future refactor PR I think we can do without it. We're testing Safemode functionality instead of Foreman's functionality here, it's as ridiculous as doing

assert Host::Managed::Jail.allowed_methods.map { |m| Host::Managed::Jail.allow?(m) }.uniq.first

@dLobatog dLobatog closed this Jan 24, 2015
@lzap
Copy link
Member Author

lzap commented Jan 27, 2015

@domcleal ping me if you want me to rebase/cherry pick thanks

@domcleal
Copy link
Contributor

already done: faeca37

@lzap
Copy link
Member Author

lzap commented Jan 28, 2015

Thank you @domcleal !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants