fixes #1899 warn if oVirt API is HTTPS-only and HTTP URL given #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,13 +41,28 @@ def clusters | |||
| client.clusters | |||
| end | |||
|
|
|||
| # Check if HTTPS is mandatory, since rest_client will fail with a POST | |||
| def test_https_required | |||
| RestClient.post url, {} if url.match /^http:/ | |||
There was a problem hiding this comment.
isnt it enough to ask if https is enabled?
There was a problem hiding this comment.
We could, though the example URL today already is HTTPS, so clearly the mistake can still be made. IMO the bug lies in the test connection button, since it reports the connection is OK currently, even though it may later fail (rest_client refuses to follow 302s with POSTs).
There was a problem hiding this comment.
I think my question was, can't we simply verify that its https in the first place? why do we actually need to post to the server?
There was a problem hiding this comment.
Good point! I checked with #ovirt, we're safe to require an HTTPS URL, so I'll do this as field validation in another PR.
h0jeZvgoxFepBQ2C
pushed a commit
to h0jeZvgoxFepBQ2C/foreman
that referenced
this pull request
Jul 26, 2018
changed to check env for bash
cfouant
pushed a commit
to cfouant/foreman
that referenced
this pull request
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://theforeman.org/issues/1899