Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes #4151 - Reports STI #2530
changed the title from
[WIP][Don't Merge] Reports STI
[WIP][Don't Merge] fixes #4151 - Reports STI
Jul 9, 2015
Waiting on contributor
Jul 12, 2015
Stringified deprecation warning version number. Changed "Chef Proxy" to "Chef" + migration to existing installations. (Please note there was a duplication with https://github.com/theforeman/foreman_chef/blob/master/db/seeds.rb#L1)
The test that's failing is a host unit test (of report imports), not a report unit test. I put an inline comment where I think it's probably failing, due to a short-circuit in the report importer code.
There's still quite a bit of support for metrics (applied, changed, failed_restarts etc) in Report that looks rather config management specific. How will these be used in other subclasses? Should they remain here or move - or would subclasses just use the fields that are most applicable to them?