Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12344 - Use Rails 4 update_all syntax in migrations #2875

Closed
wants to merge 1 commit into from

Conversation

@dLobatog
Copy link
Member

dLobatog commented Oct 29, 2015

Problem
Rails 3 syntax allows update_all(old,new), however on Rails 4 the only
way to accomplish that is where(old).update_all(new). Reports STI
contains a migration with this.

Solution
Change the migration to use the where(old).update_all(new) syntax

**Problem**
Rails 3 syntax allows `update_all(old,new)`, however on Rails 4 the only
way to accomplish that is `where(old).update_all(new)`. Reports STI
contains a migration with this.

**Solution**
Change the migration to use the `where(old).update_all(new)` syntax
@shlomizadok

This comment has been minimized.

Copy link
Member

shlomizadok commented Nov 1, 2015

👍

@unorthodoxgeek

This comment has been minimized.

Copy link
Member

unorthodoxgeek commented Nov 2, 2015

good for merge 👍

@domcleal

This comment has been minimized.

Copy link
Contributor

domcleal commented Nov 2, 2015

Merged as c3a34b7, thanks @dLobatog.

@domcleal domcleal closed this Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.