fixes #12194 - join fact tables multiple times for each search term

[domcleal]

scoped_search usually generates a new inner join for each search term
when searching through a key/value table layout to correctly search for
hosts via multiple facts. Since the change to ext_method in 3f8e6c3, a
fixed table name was used. This is changed to multiple joins to match
how scoped_search works with multiple search terms.

[domcleal]

I'm unsure if this is better or worse than scoped_search's randomness: https://github.com/wvanbergen/scoped_search/blob/v3.2.2/lib/scoped_search/query_builder.rb#L298

[ohadlevy]

👍 while I assume this will work, but wont it better to solve it in scoped search?

[domcleal]

👍 while I assume this will work, but wont it better to solve it in scoped search?

I don't think there's a directly applicable fix for scoped_search. Using ext_method replaces all of the "to_sql" mechanism in its query builder, which includes the magic that constructs queries across key/value tables. If we use ext_method at all, we're entirely responsible for passing back conditions, joins, keyparameters, keyconditions etc - there's no compromise that I can see.

If I were to change anything in scoped_search, it'd be to somehow make some of those helpers easily reusable, but it'd probably be quite invasive.

[ohadlevy]

👍 then, waiting for tests.

[ohadlevy]

merged as 57e9d8a thanks @domcleal