fixes #14076 - remove unused Puppetclass hostgroups counter #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def down | ||
| add_column :puppetclasses, :hostgroups_count, :integer, :default => 0 | ||
| HostgroupClass.all.each do |hgc| | ||
| Puppetclass.increment_counter(:hostgroups_count, hgc.puppetclass_id) |
There was a problem hiding this comment.
Not sure if it's worth the trouble for a down migration, but we can calculate this entirely in the DB with a single SQL query.
There was a problem hiding this comment.
A query to group HostgroupClass by puppetclass_id and then update each puppetclass_id's counter?
There was a problem hiding this comment.
Something along the lines of:
UPDATE puppetclasses SET hostgroups_count = (SELECT count(*) FROM hostgroup_classes WHERE hostgroup_classes.class_id = puppetclasses.id)Technically a nested query, but I think most DBs should be able to optimize it quite well. And without instantiating possibly thousands of objects.
|
This also needs fixing on this line: |
tbrisker
added
1.11.0
Waiting on contributor
and removed
Needs re-review
Needs testing
1.11.0
labels
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Thanks, fixed the rake task to not update this counter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3282.