fixes #14155 - fix leaks between tests with random ordering #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A test for the Rabl use_controller_name_as_json_root extension was leaking as the old value was only reset in `setup` methods. When the test was last in the test case, the configuration wasn't reset. - The with_env helper failed to unset environment variables that weren't set before, it now stores a nil value and resets them. - OS functional tests used a class-level `os` variable to hold default parameters, but was reassigned in some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leaking as the old value was only reset in
setupmethods. When thetest was last in the test case, the configuration wasn't reset.
set before, it now stores a nil value and resets them.
osvariable to hold defaultparameters, but was reassigned in some tests.