Fixes #14572 - fix updating storage in compute profiles based on template #3411

iNecas · 2016-04-11T10:55:41Z

No description provided.

ares · 2016-04-11T12:06:04Z

iNecas · 2016-04-11T12:59:06Z

Right, I was just telling to myself: "don't forget to search for other references to that id!" Of course I did. Luckily we have @ares watching us :)

iNecas · 2016-04-11T12:59:30Z

Fixed

ares · 2016-04-11T13:41:21Z

without #3412 the JS fails, it would be nice to rescue from this issue and add storage volumes... even with the patch it could happen with libvirt

…late

iNecas · 2016-04-11T14:12:10Z

Thanks for the review, I've added additional check to see if the networks element is available

ares · 2016-04-11T14:38:36Z

Works nicely, ACK pending Jenkins

dLobatog · 2016-04-11T15:43:24Z

@ares Jenkins says 👍

ares · 2016-04-12T07:08:25Z

so do I :-) merged as deda3a7, thanks @iNecas

theforeman-bot added Not yet reviewed Needs testing labels Apr 11, 2016

ares added Waiting on contributor and removed Needs testing Not yet reviewed labels Apr 11, 2016

iNecas force-pushed the fix-profiles branch from c45db64 to 8373633 Compare April 11, 2016 12:56

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Apr 11, 2016

ares added Waiting on contributor and removed Needs re-review Needs testing labels Apr 11, 2016

Fixes #14572 - fix updating storage in compute profiles based on temp…

fd78b19

…late

iNecas force-pushed the fix-profiles branch from 8373633 to fd78b19 Compare April 11, 2016 14:11

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Apr 11, 2016

ares removed the Needs re-review label Apr 11, 2016

ares self-assigned this Apr 11, 2016

ares added Ready to merge and removed Needs testing labels Apr 11, 2016

ares closed this Apr 12, 2016

Conversation