Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14686 - Allow scoped search on ID for organizations #3435

Closed
wants to merge 1 commit into from
Closed

Conversation

akofink
Copy link
Contributor

@akofink akofink commented Apr 18, 2016

No description provided.

@dLobatog
Copy link
Member

Merged as 6ee7a8b, thanks @akofink!

@dLobatog dLobatog closed this Apr 18, 2016
@@ -48,6 +48,7 @@ class Taxonomy < ActiveRecord::Base
after_create :assign_default_templates

scoped_search :on => :description, :complete_enabled => :false, :only_explicit => true
scoped_search :on => :id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho this should be only_explicit with no auto completer, as ID is usually not user friendly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On 04/18, Ohad Levy wrote:

@@ -48,6 +48,7 @@ class Taxonomy < ActiveRecord::Base
after_create :assign_default_templates

scoped_search :on => :description, :complete_enabled => :false, :only_explicit => true

  • scoped_search :on => :id

imho this should be only_explicit with no auto completer, as ID is usually not user friendly.

I tried to do so myself before merging, but for some reason these
parameters didn't work :/


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/theforeman/foreman/pull/3435/files/4d3873615d4b9ab38b522b981edd1142c34eb196#r60108640

Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

@akofink akofink deleted the 14686 branch June 6, 2016 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants