Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15037 - Improves editable elements in settings #3523

Closed
wants to merge 1 commit into from

Conversation

amirfefer
Copy link
Member

@amirfefer amirfefer commented May 13, 2016

Foreman uses Jeditable jquery plugin for editable elements.
This plugin is unmaintained, and lack of some features (such as optgroup in select input).

A better alternative is x-editable - well maintained and supports much more input elements, and yet simpler.
x-editable-rails gem imports x-editable to rails and makes it easy to use.

optgroup in select input:

screenshot from 2016-05-13 02-04-09

textarea input:
screenshot from 2016-05-13 10-06-57

Demonstration:

editable-gif

@amirfefer
Copy link
Member Author

[test]

@amirfefer
Copy link
Member Author

amirfefer commented May 24, 2016

Test fails randomly and doesn't related.

@dLobatog
Copy link
Member

dLobatog commented Jul 5, 2016

@amirfefer Apologies for the delay on reviewing this, I keep on getting more and more things that are 'high prio'. Anyhow, this is looking great, thanks for doing it! I have just 2 qualms about it and then we can merge:

  • This needs to be rebased
  • Can you remove the border-bottom: dashed 1px for editable-click? It's the annoying dashes under every setting, you can either override the CSS or if the library allows you to disable it, that'd be even better.

👏 Thanks, nearly ready to merge!

@amirfefer
Copy link
Member Author

amirfefer commented Jul 20, 2016

@dLobatog Thanks for the review.
The dashes can be removed only by css.

Furthermore, validation errors are presented as intended:
validations

@dLobatog
Copy link
Member

Merged as d163507, thanks @amirfefer!

@dLobatog dLobatog closed this Jul 21, 2016
@dLobatog
Copy link
Member

I've opened theforeman/foreman-packaging#1238 to package the rubygem dependency - should be in nightly shortly I think

@johnpmitsch
Copy link
Contributor

This is causing issues on Katello's "Red Hat Repositories" page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants