New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #15037 - Improves editable elements in settings #3523
Conversation
160babb
to
43871a1
Compare
|
[test] |
|
Test fails randomly and doesn't related. |
|
@amirfefer Apologies for the delay on reviewing this, I keep on getting more and more things that are 'high prio'. Anyhow, this is looking great, thanks for doing it! I have just 2 qualms about it and then we can merge:
|
|
@dLobatog Thanks for the review. |
|
Merged as d163507, thanks @amirfefer! |
|
I've opened theforeman/foreman-packaging#1238 to package the rubygem dependency - should be in nightly shortly I think |
|
This is causing issues on Katello's "Red Hat Repositories" page |

Foreman uses Jeditable jquery plugin for editable elements.
This plugin is unmaintained, and lack of some features (such as optgroup in select input).
A better alternative is x-editable - well maintained and supports much more input elements, and yet simpler.
x-editable-railsgem imports x-editable to rails and makes it easy to use.optgroup in select input:
textarea input:

Demonstration: