Join GitHub today
Fixes #13424 - c3 patternfly react implementation #3603
Some comments on what the Emitter, MountingService & friends do would be great for the casual contributor to understand what's going on. Currently I believe most contributors (including myself) would have a hard time creating components in this fashion, but I suppose comments can help that. Thanks for the effort updating the PR and now with tests (:+1) @gailsteiger
From my side,
In any case, for future PRs: a 1000+ LOC change is quite difficult and takes a lot of time to review, no matter how trivial the lines are. There are studies done on the effectiveness of code reviews and pretty much anything above ~300LOC will contain defects no matter how much code review you do, which I pretty much agree with. 
If you look at commits within the last 3 years and a half over 800 LOC -
Thanks again for keeping up with the PR @gailsteiger - it takes a lot of grit to merge big PRs like this, hopefully we can keep PRs after this much smaller and quicker to review/merge!