Refs #12364 - webpack server can serve assets on https #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mipearson/webpack-rails#49 - PR opened |
|
👍 works nice for me! |
|
Just triggered http://ci.theforeman.org/job/test_develop/2319/ to see if test_develop comes back, ready to merge if tests pass 👍 |
|
Lots of 'java.io.IOException: remote file operation failed:'.. [test]? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
42ba771 does not fix the issue completely, the policy is required but is not sufficient if the webpack server runs on the same domain as the Foreman. Browser refuses content from both
https://$domainandhttp://$domainif the domain is same in both urls. With this patch, webpack server can be started in https mode and we can configure the client to use https too in settings.yaml.There's one gotcha though, webpack_rails only supports verify_none ssl mode, I plan to send them patch and after that we can expose this option too.