Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14375 - Add search to bookmarks controller #3889

Merged
merged 1 commit into from Sep 26, 2016

Conversation

Projects
None yet
3 participants
@shlomizadok
Copy link
Member

commented Sep 26, 2016

No description provided.

@shlomizadok

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2016

Codeclimate is right. However, this belongs to a separate pull request, imho

@dLobatog

This comment has been minimized.

Copy link
Member

commented Sep 26, 2016

@shlomizadok Thanks, please add a permission for this route - then it'll pass tests and we can merge it.

@shlomizadok

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2016

@dLobatog - Added. Thanks for the heads up.

@shlomizadok

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2016

@dLobatog, all tests besides code climate are 🍏
For code climate, I have created issue #16689

@dLobatog dLobatog merged commit 2b24dd6 into theforeman:develop Sep 26, 2016

5 of 6 checks passed

codeclimate Code Climate found 10 new issues and 9 fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished.
Details
hound No violations found. Woof!
katello Build finished.
Details
upgrade Build finished.
Details
@dLobatog

This comment has been minimized.

Copy link
Member

commented Sep 26, 2016

Thanks @shlomizadok !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.