New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17439 - Moved facet base to a concern #4047

Merged
merged 1 commit into from Nov 28, 2016

Conversation

Projects
None yet
3 participants
@ShimShtein
Member

ShimShtein commented Nov 24, 2016

If the plugin that wants to create a new facet doesn't want to take the inheritance slot (for example if it already has some base class), it can include the new concern.

Fixes #17439 - Moved facet base to a concern
If the plugin that wants to create a new facet doesn't want to
take the inheritance slot (for example if it already has some
base class), it can `include` the new concern.
@ShimShtein

This comment has been minimized.

Show comment
Hide comment
@ShimShtein

ShimShtein Nov 27, 2016

Member

Rebased

Member

ShimShtein commented Nov 27, 2016

Rebased

@dLobatog dLobatog merged commit 1b38f23 into theforeman:develop Nov 28, 2016

6 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished.
Details
hound No violations found. Woof!
katello Build finished.
Details
upgrade Build finished.
Details
@dLobatog

This comment has been minimized.

Show comment
Hide comment
@dLobatog
Member

dLobatog commented Nov 28, 2016

Thanks @ShimShtein !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment