Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17808 - fix 'multipart form data' IE bug #4125

Merged
merged 1 commit into from Dec 23, 2016

Conversation

Projects
None yet
4 participants
@amirfefer
Copy link
Member

commented Dec 21, 2016

According to this bug (https://connect.microsoft.com/IE/Feedback/Details/868498),
multipart form data is malformed if there are fields without names.
It been solved within Edge browser, however no solution is expected for IE10/IE11

It cause a failure with Rack - EOFError: bad content body, therefore pages like provisioning template cannot be submitted (and all other forms which are submitted via ajax with multipart form data, and an unnamed field within).

Two suggested and tested workaround are:

  1. Add an hidden input with no meaning name
  2. Disable ajax submission form (via two-pane.js) . This bug occurs only when the form is submitted via ajax.
@mention-bot

This comment has been minimized.

Copy link

commented Dec 21, 2016

@amirfefer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ares, @lzap and @abenari to be potential reviewers.

Fixes #17808 - fix 'multipart form data' IE bug
According to this bug
(https://connect.microsoft.com/IE/Feedback/Details/868498),
multipart form data is malformed if there are fields without names.
This bug has been solved within Edge browser,
however no solution is expected for IE10/IE11

@amirfefer amirfefer force-pushed the amirfefer:17808 branch from ad2a9d8 to 5899db2 Dec 22, 2016

@@ -159,4 +159,7 @@
not have a 'name' attribute so browsers will not send them in the form POST. %>
<input type="hidden" id="old" value="<%= @template.template %>" />
<input type="hidden" id="new" value="<%= @template.template %>" />

This comment has been minimized.

Copy link
@amirfefer

amirfefer Dec 22, 2016

Author Member

Adding disabled attribute to unnamed input field doesn't solve this issue.

@dLobatog dLobatog merged commit a0e1286 into theforeman:develop Dec 23, 2016

6 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished.
Details
hound No violations found. Woof!
katello Build finished.
Details
upgrade Build finished.
Details
@dLobatog

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

Thanks @amirfefer !

evgeni added a commit to evgeni/foreman that referenced this pull request Feb 21, 2017

Fixes #18587 - fix 'multipart form data' IE bug for domains and subnets
According to this bug (https://connect.microsoft.com/IE/Feedback/Details/868498),
multipart form data is malformed if there are fields without names.
It been solved within Edge browser, however no solution is expected for IE10/IE11

It cause a failure with Rack - EOFError: bad content body, therefore pages like
domains and subnet create/edit cannot be submitted (and all other forms which are
submitted via ajax with multipart form data, and an unnamed field within).

This is identical to theforeman#4125
but on the domains and subnets pages.

evgeni added a commit to evgeni/foreman that referenced this pull request Feb 21, 2017

Fixes #18587 - fix 'multipart form data' IE bug @ domains/subnets
According to this bug [1] multipart form data is malformed if there
are fields without names. It been solved within Edge browser, however
no solution is expected for IE10/IE11

It cause a failure with Rack - EOFError: bad content body, therefore
pages like domains and subnet create/edit cannot be submitted (and all
other forms which are submitted via ajax with multipart form data, and
an unnamed field within).

This is identical to theforeman#4125
but on the domains and subnets pages.

[1] https://connect.microsoft.com/IE/Feedback/Details/868498

evgeni added a commit to evgeni/foreman that referenced this pull request Feb 21, 2017

Fixes #18587 - fix 'multipart form data' IE bug @ domains/subnets
According to this bug [1] multipart form data is malformed if there
are fields without names. It been solved within Edge browser, however
no solution is expected for IE10/IE11

It cause a failure with Rack - EOFError: bad content body, therefore
pages like domains and subnet create/edit cannot be submitted (and all
other forms which are submitted via ajax with multipart form data, and
an unnamed field within).

This is identical to theforeman#4125
but on the domains and subnets pages.

[1] https://connect.microsoft.com/IE/Feedback/Details/868498

evgeni added a commit to evgeni/foreman that referenced this pull request Feb 21, 2017

Fixes #18587, #18588 - Fix 'multipart form data' IE bug
According to this bug [1] multipart form data is malformed if there
are fields without names. It been solved within Edge browser, however
no solution is expected for IE10/IE11

It cause a failure with Rack - EOFError: bad content body, therefore
pages like domains and subnet create/edit cannot be submitted (and all
other forms which are submitted via ajax with multipart form data, and
an unnamed field within).

This is identical to theforeman#4125
but on the domains, subnets and lookup_keys pages.
it also moves the code into a helper and calls the helper instead.

[1] https://connect.microsoft.com/IE/Feedback/Details/868498

evgeni added a commit to evgeni/foreman that referenced this pull request Feb 21, 2017

Fixes #18587, #18588 - Fix 'multipart form data' IE bug
According to this bug [1] multipart form data is malformed if there
are fields without names. It been solved within Edge browser, however
no solution is expected for IE10/IE11

It cause a failure with Rack - EOFError: bad content body, therefore
pages like domains and subnet create/edit cannot be submitted (and all
other forms which are submitted via ajax with multipart form data, and
an unnamed field within).

This is identical to theforeman#4125
but on the domains, subnets and lookup_keys pages.
it also moves the code into a helper and calls the helper instead.

[1] https://connect.microsoft.com/IE/Feedback/Details/868498

evgeni added a commit to evgeni/foreman that referenced this pull request Mar 1, 2017

Fixes #18587, #18588 - Fix 'multipart form data' IE bug
According to this bug [1] multipart form data is malformed if there
are fields without names. It been solved within Edge browser, however
no solution is expected for IE10/IE11

It cause a failure with Rack - EOFError: bad content body, therefore
pages like domains and subnet create/edit cannot be submitted (and all
other forms which are submitted via ajax with multipart form data, and
an unnamed field within).

This is identical to theforeman#4125
but moves the workaround to an own helper function and calls the
function in every submit_or_cancel invocation, thus fixing *all* forms
which use the two-pane layout.

[1] https://connect.microsoft.com/IE/Feedback/Details/868498

evgeni added a commit to evgeni/foreman that referenced this pull request Mar 1, 2017

Fixes #18587, #18588 - Fix 'multipart form data' IE bug
According to this bug [1] multipart form data is malformed if there
are fields without names. It been solved within Edge browser, however
no solution is expected for IE10/IE11

It cause a failure with Rack - EOFError: bad content body, therefore
pages like domains and subnet create/edit cannot be submitted (and all
other forms which are submitted via ajax with multipart form data, and
an unnamed field within).

This is identical to theforeman#4125
but moves the workaround to an own helper function and calls the
function in every submit_or_cancel invocation, thus fixing *all* forms
which use the two-pane layout.

[1] https://connect.microsoft.com/IE/Feedback/Details/868498

tbrisker added a commit that referenced this pull request Mar 8, 2017

Fixes #18587, #18588 - Fix 'multipart form data' IE bug
According to this bug [1] multipart form data is malformed if there
are fields without names. It been solved within Edge browser, however
no solution is expected for IE10/IE11

It cause a failure with Rack - EOFError: bad content body, therefore
pages like domains and subnet create/edit cannot be submitted (and all
other forms which are submitted via ajax with multipart form data, and
an unnamed field within).

This is identical to #4125
but moves the workaround to an own helper function and calls the
function in every submit_or_cancel invocation, thus fixing *all* forms
which use the two-pane layout.

[1] https://connect.microsoft.com/IE/Feedback/Details/868498

domcleal added a commit that referenced this pull request Mar 29, 2017

Fixes #18587, #18588 - Fix 'multipart form data' IE bug
According to this bug [1] multipart form data is malformed if there
are fields without names. It been solved within Edge browser, however
no solution is expected for IE10/IE11

It cause a failure with Rack - EOFError: bad content body, therefore
pages like domains and subnet create/edit cannot be submitted (and all
other forms which are submitted via ajax with multipart form data, and
an unnamed field within).

This is identical to #4125
but moves the workaround to an own helper function and calls the
function in every submit_or_cancel invocation, thus fixing *all* forms
which use the two-pane layout.

[1] https://connect.microsoft.com/IE/Feedback/Details/868498

(cherry picked from commit 8cc2651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.