Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #17895 - do not import link-local ipv6 addr fact #4439

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
None yet
5 participants
@timogoebel
Copy link
Member

commented Apr 6, 2017

If facter reports a link-local ipv6 address as an interfaces primary ipv6 address, drop the address from the interface and either remove an existing address or simply don't set the address.

@mention-bot

This comment has been minimized.

Copy link

commented Apr 6, 2017

@timogoebel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dLobatog, @ares and @domcleal to be potential reviewers.

@tbrisker

This comment has been minimized.

Copy link
Member

commented Apr 6, 2017

@timogoebel Mind rebasing this on latest develop? looks like katello tests are failing because of that.

@timogoebel timogoebel force-pushed the timogoebel:17895-link-local-ipv6 branch from b1adf85 to 9e74056 Apr 7, 2017

@timogoebel

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2017

@tbrisker : Rebased.

@lzap

lzap approved these changes Apr 7, 2017

Copy link
Member

left a comment

WFM thanks!

@lzap lzap merged commit 34c2e24 into theforeman:develop Apr 7, 2017

5 of 6 checks passed

codeclimate Code Climate is analyzing this code.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished.
Details
hound No violations found. Woof!
katello Build finished.
Details
upgrade Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.