Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21766 - Enforce uniquness of TaxableTaxonomy in DB #5028

Merged
merged 1 commit into from Nov 27, 2017

Conversation

tbrisker
Copy link
Member

No description provided.

@theforeman-bot
Copy link
Member

Issues: #21766

@ares
Copy link
Member

ares commented Nov 27, 2017

[test foreman] - failures seemed as jenkins issue, for katello it fails on migration having [5.0], the same for upgrades

Caused by:
NoMethodError: undefined method `[]' for #<ActiveRecord::Migration:0x000000008a9378>
/usr/local/rvm/gems/ruby-2.2.5@test_develop_pr_upgrade-2/gems/activerecord-4.2.9/lib/active_record/migration.rb:664:in `block in method_missing'
/usr/local/rvm/gems/ruby-2.2.5@test_develop_pr_upgrade-2/gems/activerecord-4.2.9/lib/active_record/migration.rb:634:in `block in say_with_time'
/usr/local/rvm/gems/ruby-2.2.5@test_develop_pr_upgrade-2/gems/activerecord-4.2.9/lib/active_record/migration.rb:634:in `say_with_time'
/usr/local/rvm/gems/ruby-2.2.5@test_develop_pr_upgrade-2/gems/activerecord-4.2.9/lib/active_record/migration.rb:654:in `method_missing'
/usr/local/rvm/gems/ruby-2.2.5@test_develop_pr_upgrade-2/gems/activerecord-4.2.9/lib/active_record/migration.rb:416:in `method_missing'
/var/lib/workspace/workspace/test_develop_pr_upgrade/database/postgresql/old_branch/1.14-stable/ruby/2.2/db/migrate/20171126131104_remove_duplicate_taxable_taxonomies.rb:1:in 

@tbrisker
Copy link
Member Author

Thanks, pushed again without versioned migration.

Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbrisker Apparently the deletion of duplicate TaxableTaxonomy generates a query that is invalid in MySQL

@tbrisker
Copy link
Member Author

@dLobatog thanks, pushed with a less-performant version that will hopefully work on mysql as well.

@ares
Copy link
Member

ares commented Nov 27, 2017

LGTM, anything else @dLobatog or good to merge?

@dLobatog dLobatog merged commit c5787ac into theforeman:develop Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants