Fixes #22382 - Remove ldap_filter 255 chars limit #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #22382 |
houndci-bot
reviewed
Jan 24, 2018
| @@ -16,12 +16,12 @@ def setup | |||
| should allow_value('').for(:ldap_filter) | |||
| should allow_value(' ').for(:ldap_filter) | |||
| should allow_value('key=value').for(:ldap_filter) | |||
| should allow_value("key=#{"a" * 256}").for(:ldap_filter) | |||
There was a problem hiding this comment.
Prefer single-quoted strings inside interpolations.
|
LGTM, just rubocop is not happy |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
[test foreman] |
tbrisker
requested changes
Jan 28, 2018
| @@ -0,0 +1,5 @@ | |||
| class RemoveLimitLdapFilter < ActiveRecord::Migration[5.1] | |||
| def change | |||
| change_column 'auth_sources', :ldap_filter, :text, :limit => nil | |||
There was a problem hiding this comment.
This migration is irreversible, you need to make an up/down migration (since it doesn't know what the old limit is)
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
tbrisker
requested changes
Jan 29, 2018
| end | ||
|
|
||
| def down | ||
| change_column 'auth_sources', :ldap_filter, :string, :limit => 255 |
There was a problem hiding this comment.
The previous schema allowed :null => true as well
There was a problem hiding this comment.
@tbrisker I think that's by default, t.string "ldap_filter", limit: 255 - if you see schema.rb only :null => false is ever specified
tbrisker
approved these changes
Jan 29, 2018
|
Thanks @dLobatog ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.