Fixes #22849 - update rubocop to 0.54 #5309
Conversation
|
Issues: #22849 |
.rubocop_todo.yml
Outdated
| # Offense count: 89 | ||
| # Offense count: 1 | ||
| # Configuration parameters: AllowSafeAssignment. | ||
| Lint/AssignmentInCondition: |
There was a problem hiding this comment.
@bastilian could you have a look there? It's app/services/report_scanner/puppet_report_scanner.rb:5
There was a problem hiding this comment.
Sorry for the delay. Here: #5341
bundler.d/development.rb
Outdated
| @@ -1,6 +1,6 @@ | |||
| group :development do | |||
| gem 'maruku', '~> 0.7' | |||
| gem 'rubocop', '0.52.1' | |||
| gem 'rubocop', '~> 0.53.0' | |||
There was a problem hiding this comment.
hound seems to still be on 0.52.1 (https://github.com/houndci/linters/blob/master/Gemfile.lock#L78), so it won't benefit from the new rules until they upgrade their version
.rubocop_todo.yml
Outdated
| # Configuration parameters: Blacklist. | ||
| # Blacklist: END, (?-mix:EO[A-Z]{1}) | ||
| Naming/HeredocDelimiterNaming: | ||
| Enabled: false | ||
|
|
||
| # Offense count: 19 | ||
| Naming/MemoizedInstanceVariableName: |
There was a problem hiding this comment.
should we add new issues in redmine for new cops?
There was a problem hiding this comment.
I would say only if one does open a PR for fixing.
mmoll
changed the title
|
https://github.com/houndci/linters/pull/184 got merged |
|
Needs ack from @theforeman/packaging so GH permits merging. |
|
@mmoll i merged the other rubocop pr, so this will need rebasing or regenerating the todo file |
[ci skip]
[ci skip]