New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23115 - session is used instead session_safe #5400

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
3 participants
@lzap
Member

lzap commented Apr 4, 2018

We removed "session_safe" flag, it's now called "session" and it is safe
by default. This passes it into proxy correctly instead generating it's
own id.

@theforeman-bot

This comment has been minimized.

Member

theforeman-bot commented Apr 4, 2018

Issues: #23115

@mmoll

mmoll approved these changes Apr 6, 2018

@mmoll mmoll merged commit e5e1523 into theforeman:develop Apr 6, 2018

6 of 7 checks passed

katello Build finished.
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished.
Details
hound No violations found. Woof!
prprocessor Commit message style is correct
Details
upgrade Build finished.
Details
@mmoll

This comment has been minimized.

Member

mmoll commented Apr 6, 2018

merged, díky @lzap!

@lzap lzap deleted the lzap:session-safe-removed-23115 branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment