New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23240 - BreadcrumbBar prop-type warnings #5441

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
3 participants
@sharvit
Contributor

sharvit commented Apr 12, 2018

No description provided.

@theforeman-bot

This comment has been minimized.

Member

theforeman-bot commented Apr 12, 2018

Issues: #23240

<ListGroupItem {...createItemProps(resource)}>
<EllipsisWithTooltip>{resource.name}</EllipsisWithTooltip>
</ListGroupItem>
))}

This comment has been minimized.

@sharvit

sharvit Apr 12, 2018

Contributor

Just prettier

@@ -92,7 +92,7 @@ BreadcrumbSwitcherPopover.propTypes = {
totalPages: PropTypes.number,
onResourceClick: PropTypes.func,
resources: PropTypes.arrayOf(PropTypes.shape({
id: PropTypes.string.isRequired,
id: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,

This comment has been minimized.

@sharvit

sharvit Apr 12, 2018

Contributor

Actually fix the issue, id should be string or number

adamruzicka pushed a commit to adamruzicka/foreman that referenced this pull request Apr 12, 2018

@tbrisker

makes sense, thanks @sharvit !

@tbrisker tbrisker merged commit 8452e8d into theforeman:develop Apr 16, 2018

8 checks passed

Hound No violations found. Woof!
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on develop at 79.479%
Details
foreman Build finished. 33093 tests run, 8 skipped, 0 failed.
Details
katello Build finished. 3583 tests run, 9 skipped, 0 failed.
Details
prprocessor Commit message style is correct
Details
upgrade Build finished. No test results found.
Details

@tbrisker tbrisker added this to the 1.18.0 milestone Apr 16, 2018

@tbrisker

This comment has been minimized.

Member

tbrisker commented Apr 16, 2018

cherry-picked to 1.18-stable as b6bc227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment