New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #23178 - seeded location should be in seeded org #5573

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
4 participants
@stbenjam
Member

stbenjam commented May 16, 2018

When creating a host in the seeded org and seeded loc, host saves and
then organization becomes invalid: "Locations expecting locations used
by hosts or inherited (check mismatches report)."

@theforeman-bot

This comment has been minimized.

Show comment
Hide comment
@theforeman-bot
Member

theforeman-bot commented May 16, 2018

Issues: #23178

@akofink

This seems fine, but how do I 'fix' an existing system? I've tried running SEED_LOCATION=true SEED_ORGANIZATION=true bundle exec rake db:seed, but my org still doesn't contain the location.

Show outdated Hide outdated db/seeds.d/050-taxonomies.rb
@stbenjam

This comment has been minimized.

Show comment
Hide comment
@stbenjam

stbenjam May 29, 2018

Member

I didn't think we could really fix existing environments, we don't know what SEED_ taxonomies were at installation, and if there's mismatches, they may be a real problem. Perhaps there shouldn't be an "Accounting" org server in "London" location and the admins want to see that on the mismatches page.

The user can fix these from the Organization screen with the "Fix Mismatches" buton.

Member

stbenjam commented May 29, 2018

I didn't think we could really fix existing environments, we don't know what SEED_ taxonomies were at installation, and if there's mismatches, they may be a real problem. Perhaps there shouldn't be an "Accounting" org server in "London" location and the admins want to see that on the mismatches page.

The user can fix these from the Organization screen with the "Fix Mismatches" buton.

@akofink

This comment has been minimized.

Show comment
Hide comment
@akofink

akofink May 29, 2018

Contributor

Ok, I'm fine with that. I didn't realize the mismatch report was even a thing! :)

Contributor

akofink commented May 29, 2018

Ok, I'm fine with that. I didn't realize the mismatch report was even a thing! :)

@akofink

Code looks good. Test failures seem related?

fixes #23178 - seeded location should be in seeded org
When creating a host in the seeded org and seeded loc, host saves and
then organization becomes invalid: "Locations expecting locations used
by hosts or inherited (check mismatches report)."
@stbenjam

This comment has been minimized.

Show comment
Hide comment
@stbenjam

stbenjam May 30, 2018

Member

Green tests, was a typo

Member

stbenjam commented May 30, 2018

Green tests, was a typo

@stbenjam

This comment has been minimized.

Show comment
Hide comment
@stbenjam

stbenjam Jun 4, 2018

Member

@theforeman/core Any chance someone with commit access could review this please?

Member

stbenjam commented Jun 4, 2018

@theforeman/core Any chance someone with commit access could review this please?

@tbrisker

makes sense, thanks @stbenjam !

@tbrisker tbrisker merged commit 86ac65a into theforeman:develop Jun 5, 2018

7 checks passed

Hound No violations found. Woof!
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished. 33754 tests run, 8 skipped, 0 failed.
Details
katello Build finished. 3700 tests run, 9 skipped, 0 failed.
Details
prprocessor Commit message style is correct
Details
upgrade Build finished. No test results found.
Details

@stbenjam stbenjam deleted the stbenjam:loc-in-org branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment