Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23818 - Update fog-openstack to save OpenStack OSP 12 #5660

Merged
merged 1 commit into from Jun 8, 2018

Conversation

Projects
None yet
4 participants
@dLobatog
Copy link
Member

commented Jun 6, 2018

On fog-openstack 0.1.23, Excon expects a 200 when it creates the first
key-pair on OpenStack. On recent versions, it returns a 201.
There is a fix for it on fog-openstack 0.1.25, so we should update to it
both in Foreman and in packaging.

theforeman/foreman-packaging#2616

If this can be cherry-picked to 1.18, 1.17 I think it'd be a good idea. The packaging PR should take care of it though, as it's >= 1.11 cc @xprazak2

Fixes #23818 - Update fog-openstack to save OpenStack OSP 12
On fog-openstack 0.1.23, Excon expects a 200 when it creates the first
key-pair on OpenStack. On recent versions, it returns a 201.
There is a fix for it on fog-openstack 0.1.25, so we should update to it
both in Foreman and in packaging.
@theforeman-bot

This comment has been minimized.

Copy link
Member

commented Jun 6, 2018

Issues: #23818

@mmoll

mmoll approved these changes Jun 6, 2018

@tbrisker
Copy link
Member

left a comment

I'm guessing we want the packaging side merged first, right?

@mmoll mmoll merged commit 5c45eb8 into theforeman:develop Jun 8, 2018

6 of 7 checks passed

foreman Build finished. 34457 tests run, 5 skipped, 24 failed.
Details
Hound No violations found. Woof!
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
katello Build finished. 3780 tests run, 9 skipped, 0 failed.
Details
prprocessor Commit message style is correct
Details
upgrade Build finished. No test results found.
Details
@mmoll

This comment has been minimized.

Copy link
Member

commented Jun 8, 2018

merged, gracias @dLobatog!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.