Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cp] Fixes #23391, #23251 - adjust breadcrumbs switcher to pf design #5724

Merged
merged 1 commit into from Jun 25, 2018

Conversation

amirfefer
Copy link
Member

Cherry picked from commit 5b16c

@theforeman-bot
Copy link
Member

Issues: #23391 #23251

@amirfefer amirfefer changed the title Fixes #23391, #23251 - adjsut breadcrumbs swticher to pf design [cp] Fixes #23391, #23251 - adjsut breadcrumbs swticher to pf design Jun 20, 2018
@tbrisker tbrisker added this to the 1.18.0 milestone Jun 21, 2018
@xprazak2
Copy link
Contributor

js test failing due to a known issue, #5720 needs to get in first for tests to pass

@ohadlevy ohadlevy changed the title [cp] Fixes #23391, #23251 - adjsut breadcrumbs swticher to pf design [cp] Fixes #23391, #23251 - adjust breadcrumbs switcher to pf design Jun 21, 2018
@tbrisker tbrisker requested a review from xprazak2 June 24, 2018 12:31
@tbrisker
Copy link
Member

related PR was merged, please rebase on latest 1.18-stable @amirfefer

@amirfefer
Copy link
Member Author

rebased.

Copy link
Contributor

@xprazak2 xprazak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foreman tests are green, merging. Thanks!

@xprazak2 xprazak2 merged commit ae790da into theforeman:1.18-stable Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants