Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19891 - Disable Style/PreferredHashMethods cop #6051

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
4 participants
@mmoll
Copy link
Member

mmoll commented Sep 8, 2018

No description provided.

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Sep 8, 2018

Issues: #19891

@mmoll

This comment has been minimized.

Copy link
Member Author

mmoll commented Sep 8, 2018

react 👍 for merging and enabling this cop (.key?, 71 changes)
react 😆 for enabling this cop, but with the "verbose" style (.has_key?, 122 changes)
react 👎 for disabling this cop, allowing both styles

@mmoll mmoll force-pushed the mmoll:PreferredHashMethods branch from b4958dd to c877203 Oct 28, 2018

@mmoll

This comment has been minimized.

Copy link
Member Author

mmoll commented Oct 28, 2018

rebased, more votes, please :)

@lzap

This comment has been minimized.

Copy link
Member

lzap commented Nov 7, 2018

Stalemate, looks like we keep it as is :)

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Nov 7, 2018

Should we allow both because of the stale mate?

@lzap

This comment has been minimized.

Copy link
Member

lzap commented Nov 9, 2018

I'd definitely prefer that.

@mmoll mmoll force-pushed the mmoll:PreferredHashMethods branch from c877203 to f15855a Nov 9, 2018

@mmoll mmoll changed the title Fixes #19891 - Fix Style/PreferredHashMethods cop Fixes #19891 - Disable Style/PreferredHashMethods cop Nov 9, 2018

@mmoll

This comment has been minimized.

Copy link
Member Author

mmoll commented Nov 9, 2018

🆗 disabled this cop

@lzap

lzap approved these changes Nov 14, 2018

@lzap lzap merged commit 7709541 into theforeman:develop Nov 14, 2018

6 of 7 checks passed

katello Build finished. 4080 tests run, 9 skipped, 1 failed.
Details
Hound No violations found. Woof!
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished. 36784 tests run, 5 skipped, 0 failed.
Details
prprocessor Commit message style is correct
Details
upgrade Build finished. No test results found.
Details
@lzap

This comment has been minimized.

Copy link
Member

lzap commented Nov 14, 2018

Thanks!

@mmoll mmoll deleted the mmoll:PreferredHashMethods branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.