Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25295 - ignore broken vmware machines #6168

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
4 participants
@m-bucher
Copy link
Contributor

m-bucher commented Oct 24, 2018

VMWare Machine Listing in ComputeResource, needs to filter virtual-machines with id==nil
Otherwise the template fails and the page shows:

There was an error listing VMs: 500 Internal Server Error

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Oct 24, 2018

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

1 similar comment
@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Oct 24, 2018

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Oct 24, 2018

Issues: #25295

@timogoebel
Copy link
Member

timogoebel left a comment

Looks good.

@timogoebel

This comment has been minimized.

Copy link
Member

timogoebel commented Oct 24, 2018

ok to test

@tbrisker
Copy link
Member

tbrisker left a comment

Test failure is unrelated. Thank you @m-bucher and welcome 😃

@tbrisker tbrisker merged commit 0c08b71 into theforeman:develop Oct 25, 2018

6 of 7 checks passed

foreman Build finished. 29230 tests run, 4 skipped, 0 failed.
Details
Hound No violations found. Woof!
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
katello Build finished. 4053 tests run, 9 skipped, 0 failed.
Details
prprocessor Commit message style is correct
Details
upgrade Build finished. No test results found.
Details

@m-bucher m-bucher deleted the ATIX-AG:broken_vm_breaks_listing branch Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.