Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25542 - Storybook style fixes #6280

Merged
merged 3 commits into from Dec 8, 2018

Conversation

Projects
None yet
5 participants
@tstrachota
Copy link
Member

tstrachota commented Nov 26, 2018

  • adds a wrapper component Story that ensures all stories have consistent spacing
  • replaces dependecies loaded from cloudflare with correct configuration for webpack loaders
  • moves components that are not intended for reuse into a section "Page chunks"
@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Nov 26, 2018

Issues: #25542

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 26, 2018

Coverage Status

Coverage remained the same at 69.079% when pulling 06cd35e on tstrachota:storybook_style_fixes into ba99da2 on theforeman:develop.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 26, 2018

Coverage Status

Coverage remained the same at 69.079% when pulling 06cd35e on tstrachota:storybook_style_fixes into ba99da2 on theforeman:develop.

@tstrachota

This comment has been minimized.

Copy link
Member Author

tstrachota commented Nov 26, 2018

Deployed for testing here:
https://tstrachota.github.io/foreman/

I had some troubles with js reaching out of memory when I was building the storybook. Could someone try if you experience the same or if it's just my setup?

@tstrachota tstrachota force-pushed the tstrachota:storybook_style_fixes branch from 06cd35e to aec6d5e Dec 5, 2018

@tstrachota

This comment has been minimized.

Copy link
Member Author

tstrachota commented Dec 5, 2018

Rebased

@waldenraines
Copy link
Contributor

waldenraines left a comment

LGTM.

@mmoll

mmoll approved these changes Dec 8, 2018

Copy link
Member

mmoll left a comment

looks much better, indeed 👍

@mmoll mmoll merged commit b0a9b86 into theforeman:develop Dec 8, 2018

5 of 7 checks passed

codeclimate 2 issues to fix
Details
upgrade Build finished. No test results found.
Details
Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished. 36736 tests run, 5 skipped, 0 failed.
Details
katello Build finished. 4115 tests run, 9 skipped, 0 failed.
Details
prprocessor Commit message style is correct
Details
@mmoll

This comment has been minimized.

Copy link
Member

mmoll commented Dec 8, 2018

merged, díky @tstrachota!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.