Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25712 - Remove org_loc_string helper #6344

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@tbrisker
Copy link
Member

tbrisker commented Dec 17, 2018

No description provided.

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Dec 17, 2018

Issues: #25712

@mmoll

This comment has been minimized.

Copy link
Member

mmoll commented Dec 17, 2018

test failures related 💔

@tbrisker tbrisker force-pushed the tbrisker:25712 branch from 5bc5afd to bd4fed2 Dec 17, 2018

@tbrisker

This comment has been minimized.

Copy link
Member Author

tbrisker commented Dec 17, 2018

@mmoll i think i fixed them all

@mmoll

mmoll approved these changes Dec 18, 2018

@mmoll mmoll merged commit 6d89a43 into theforeman:develop Dec 18, 2018

7 checks passed

Hound No violations found. Woof!
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished. 36124 tests run, 15 skipped, 0 failed.
Details
katello Build finished. 4118 tests run, 9 skipped, 0 failed.
Details
prprocessor Commit message style is correct
Details
upgrade Build finished. No test results found.
Details
@mmoll

This comment has been minimized.

Copy link
Member

mmoll commented Dec 18, 2018

merged, thanks @tbrisker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.