Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #25882 - use working iterator for webpack entries #6429

Merged
merged 1 commit into from Jan 22, 2019

Conversation

@jlsherrill
Copy link
Contributor

jlsherrill commented Jan 22, 2019

No description provided.

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Jan 22, 2019

Issues: #25882

Copy link
Contributor

sharvit left a comment

LGTM

Copy link
Member

tbrisker left a comment

Tested this with several plugins (but not katello) and compilation seems to work now. Can someone with a working katello dev setup apply this and check if the webpack compilation works properly?

@jturel

This comment has been minimized.

Copy link
Contributor

jturel commented Jan 22, 2019

Taking a look @ Katello

@jlsherrill

This comment has been minimized.

Copy link
Contributor Author

jlsherrill commented Jan 22, 2019

@tbrisker i ran:

node_modules/webpack/bin/webpack.js --config config/webpack.config.js --bail --env.pluginName=katello

and saw both katello and katello:common get compiled:

             katello/katello.js  3.24 MB      30  [emitted]  [big]  katello
              katello/bundle.js  1.45 MB      31  [emitted]  [big]  bundle
      katello/katello:common.js     3 MB      32  [emitted]  [big]  katello:common
              katello/vendor.js  27.7 MB      33  [emitted]  [big]  vendor

also checked the generated manifest.json:

    "katello": [
      "katello/katello.js",
      "katello/katello.css"
    ],
    "bundle": [
      "katello/bundle.js",
      "katello/bundle.css"
    ],
    "katello:common": "katello/katello:common.js",

which i believe looks right (was missing katello:common previously)

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 22, 2019

Coverage Status

Coverage remained the same at 69.674% when pulling faa7758 on jlsherrill:25882_2 into 1e3ecae on theforeman:develop.

@jturel

This comment has been minimized.

Copy link
Contributor

jturel commented Jan 22, 2019

Before patch:

I, [2019-01-22T16:28:50.322686 #13936]  INFO -- : Writing /home/vagrant/katello/public/assets/katello/widgets/tabs-dab9b127ac0fb65d3066c7f30ece8a4a542854cb6766127d25b0a21b016d4bc8.css.gz                                                                                     
/home/vagrant/foreman/node_modules/webpack/bin/webpack.js --config /home/vagrant/foreman/config/webpack.config.js --bail --env.pluginName=katello                                                                                                                              
/home/vagrant/foreman/config/webpack.config.js:74
    for (var entry of plugins['entries']) {
                           ^

TypeError: plugins.entries[Symbol.iterator] is not a function
    at module.exports.env (/home/vagrant/foreman/config/webpack.config.js:74:28)
    at handleFunction (/home/vagrant/foreman/node_modules/webpack/lib/prepareOptions.js:26:13)
    at prepareOptions (/home/vagrant/foreman/node_modules/webpack/lib/prepareOptions.js:11:13)
    at requireConfig (/home/vagrant/foreman/node_modules/webpack/bin/convert-argv.js:98:14)
    at /home/vagrant/foreman/node_modules/webpack/bin/convert-argv.js:104:17
    at Array.forEach (native)

After patch:

                 katello/katello-146c94e21fe60903ccea.js.gz     126 kB          [emitted]
              katello/bundle-447cf1da8a6273d7d28a.js.map.gz     164 kB          [emitted]                                                                                                                                                                                      
             katello/katello-146c94e21fe60903ccea.js.map.gz     352 kB          [emitted]  [big]                                                                                                                                                                                
      katello/katello:common-f8a96a579eba9f209ee7.js.map.gz     369 kB          [emitted]  [big]
                  katello/vendor-385bdafcd166b9d752a4.js.gz    1.39 MB          [emitted]  [big]
              katello/vendor-385bdafcd166b9d752a4.js.map.gz    3.32 MB          [emitted]  [big] 

Looks good!

@jturel
jturel approved these changes Jan 22, 2019
@ekohl ekohl merged commit 92a0079 into theforeman:develop Jan 22, 2019
8 checks passed
8 checks passed
Hound No violations found. Woof!
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 69.674%
Details
foreman Build finished. 36842 tests run, 15 skipped, 0 failed.
Details
katello Build finished. 4150 tests run, 9 skipped, 0 failed.
Details
prprocessor Commit message style is correct
Details
upgrade Build finished. No test results found.
Details
@jlsherrill jlsherrill deleted the jlsherrill:25882_2 branch Jan 22, 2019
@tbrisker

This comment has been minimized.

Copy link
Member

tbrisker commented Jan 23, 2019

93e9a04 is the 1.21-stable cherrypick for the record

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.