Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25961 - report expiration record disappearing #6455

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
5 participants
@lzap
Copy link
Member

commented Feb 1, 2019

During the refactoring to use batch processing I changed
messages/sources deletion from distinct approach to direct approach.
I've missed that this actually deletes records, even those still
associated to different reports.

I am putting the distinct queries back, but putting them outside of the
batch loop because they can be executed just once after deletion is
done.

@theforeman-bot

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

Issues: #25961

Show resolved Hide resolved app/models/report.rb Outdated
Show resolved Hide resolved app/models/report.rb Outdated
Show resolved Hide resolved app/models/report.rb Outdated

@lzap lzap force-pushed the lzap:report-expire-disappearing-25961 branch from 87c183d to 414180e Feb 1, 2019

@lzap

This comment has been minimized.

Copy link
Member Author

commented Feb 1, 2019

How about now?

@lzap lzap force-pushed the lzap:report-expire-disappearing-25961 branch from 414180e to 3a6c7d7 Feb 5, 2019

@iNecas

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

@lzap mind adding 'reproducer steps' so that people that's reporting is not their daily bread can still help reviewing?

@tbrisker
Copy link
Member

left a comment

Thanks @lzap !

@tbrisker tbrisker merged commit 2414161 into theforeman:develop Feb 6, 2019

7 checks passed

Hound No violations found. Woof!
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished. 36857 tests run, 15 skipped, 0 failed.
Details
katello Build finished. 4153 tests run, 9 skipped, 0 failed.
Details
prprocessor Commit message style is correct
Details
upgrade Build finished. No test results found.
Details
@tbrisker

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

1.21- 5cedb38
1.20- df2bbad

@lzap lzap deleted the lzap:report-expire-disappearing-25961 branch Feb 8, 2019

@lzap

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

Sorry @iNecas it's foreman-rake reports:expire to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.