Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #26172 - Added ability to override repository with cost #6514

Closed

Conversation

@tchellomello
Copy link

tchellomello commented Feb 27, 2019

Added ability to set a cost for all repositories during build time (cloud-init, kickstart) which will force yum or dnf to prioritize which repository to pick when the two repositories offer the same content.

Redmine Tracker: https://projects.theforeman.org/issues/26172

This worked effectively and increased the speed on cloud-init builds.

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Feb 27, 2019

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

2 similar comments
@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Feb 27, 2019

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Feb 27, 2019

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Feb 27, 2019

Issues: #26172

@theforeman-bot

This comment has been minimized.

Copy link
Member

theforeman-bot commented Feb 27, 2019

There were the following issues with the commit message:

  • length of the first commit message line for 3c4773a exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@tchellomello tchellomello force-pushed the tchellomello:enable_repository_cost branch from 3c4773a to 620d02d Feb 27, 2019
@tchellomello tchellomello changed the title Fixes #26172 - Added ability to override repository with cost property Fixes #26172 - Added ability to override repository with cost Feb 27, 2019
@ares

This comment has been minimized.

Copy link
Member

ares commented Feb 27, 2019

Thanks for the patch. It actually needs to be open against different repo that we sync to this repo. Please open the same against this file https://github.com/theforeman/community-templates/blob/develop/provisioning_templates/snippet/redhat_register.erb

@timogoebel timogoebel closed this Feb 27, 2019
@tchellomello tchellomello deleted the tchellomello:enable_repository_cost branch Feb 27, 2019
@tchellomello

This comment has been minimized.

Copy link
Author

tchellomello commented Feb 27, 2019

@ares PR opened at theforeman/community-templates#559

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.