fixes #26052 - add missing IDs to Layout

[glekner]

No description provided.

[theforeman-bot]

Issues: #26052

[glekner]

I'm using the url (e.g. Hardware Models is menu_item_models for the new attributes.
I assumed dividers don't need the additional attributes.

[glekner]

Dashboard url is / so the attributes are wrong

<a id="menu_item_" data-id="aid_" href="/"><span class="list-group-item-value">Dashboard</span></a>

maybe we should hardcode the attributes in the server @ohadlevy ?

[waldenraines]

@lhellebr you may want to have a look at this as I'm not sure what the IDs were prior to the react navigation.

[tbrisker]

A couple of comments -

1. This does not restore the same ids for the menu items as before. The original id was generated by the item name - https://github.com/theforeman/foreman/blob/1.19-stable/app/helpers/home_helper.rb#L41. This means that changing it to be based on the url will still cause multiple failures for QE automation.
2. The data aid attribute should no longer be used by automation - see Fixes #23168 - undefined method `split' for nil:NilClass #5712 (comment) and SatelliteQE/airgun@8438e72 which dropped it completely, so we don't need to continue using this attribute which was only used for QE automation.

[glekner]

removed data-id and changed id to item.name
Also opened a quick fix PR because right now theres an empty data-id attribute

[glekner]

• rebased and updated PF version, so data-id isn't shown anymore

[tbrisker]

See inline comment; this also needs updating the react-patternfly rpm version

[coveralls]

Coverage remained the same at 67.373% when pulling 276eb19 on glekner:verticalnav-ids into ef73d68 on theforeman:develop.

[glekner]

@tbrisker can we merge? aid is no longer used

[tbrisker]

Thanks @glekner! I didn't notice that you pushed the update a couple of weeks ago.