Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #22467 - removed unreachable code #6603

Merged
merged 1 commit into from Mar 24, 2019

Conversation

lzap
Copy link
Member

@lzap lzap commented Mar 21, 2019

A refactoring in #22467 left one bit behind, this removes it. Progress
is now reported without "in progress" string which is fine as it's
presented just below status which clearly states "Pending installation".

@theforeman-bot
Copy link
Member

Issues: #22467

@alexjfisher
Copy link
Contributor

@lzap But it use to say how long the build had been in progress for. Can't we get this working again?

I made a start in #6505 but need a bit of help.

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally refs should only be used in case the original issue hasn't been shipped in a release yet, but in this case the is clearly code that is unreachable so i'm fine with doing it without a matching ticket. Thanks @lzap !

@tbrisker tbrisker merged commit 9c2d429 into theforeman:develop Mar 24, 2019
@lzap lzap deleted the improve-inprogress-22467 branch April 2, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants