Fixes #27662 - template inputs - adding field #6991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #27662 |
ezr-ondrej
force-pushed
the
fix_template_inputs
branch
from
621c2d9
to
2f86d7e
Compare
|
@tbrisker would you mind taking a look since you reviewed and merged the referred PR? |
ezr-ondrej
commented
Sep 3, 2019
| @@ -42,10 +42,11 @@ export const pollReportData = url => { | |||
| export const inputValueOnchange = input => { | |||
| const searchValue = input.value === 'search'; | |||
| const plainValue = input.value === 'plain'; | |||
| const inputId = input.dataset.item || ''; | |||
| const inputId = input.dataset.item; | |||
| const $fields = $(input).closest('.fields'); | |||
There was a problem hiding this comment.
this just narrows the scope, not to search everywhere.
|
[test foreman] |
|
[test foreman] |
|
@ezr-ondrej maybe rebase is needed? FTR there was ~150 tests failures in ProxyApiBmcTest which is 99.99% unrelated |
ezr-ondrej
force-pushed
the
fix_template_inputs
branch
from
2f86d7e
to
e210149
Compare
|
Rebased. |
|
💚 |
xprazak2
approved these changes
Sep 5, 2019
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper fix for #6955, fixes the new template inputs identification in javascript.
f.indexis set by Rails if the builder isfields_for