Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #29135 - fix section paramter in links #7682

Merged
merged 1 commit into from May 21, 2020
Merged

Refs #29135 - fix section paramter in links #7682

merged 1 commit into from May 21, 2020

Conversation

ShimShtein
Copy link
Member

Now the parameter can accept any input including dots

@ShimShtein
Refs #29135 - fix section paramter in links
7882f56 
Now the parameter can accept any input including dots
@theforeman-bot
Copy link
Member

Issues: #29135

tbrisker
tbrisker approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well. As a side note, I noticed clicking on the documentation button opens the link in the same tab, iirc in the past we opened it in a new tab?

@tbrisker tbrisker merged commit 971b2f6 into theforeman:develop May 21, 2020
@tbrisker
Copy link
Member

2.1 - 2fe085d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@ShimShtein @theforeman-bot @tbrisker