Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #30097 - media provider friendly_name method removed #7740

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fixes #30097 - media provider friendly_name method removed #7740

merged 1 commit into from
Jun 11, 2020

Conversation

lzap
Copy link
Member

@lzap lzap commented Jun 10, 2020

Ruby Class does not have friendly_name method, this hasn't been
working. I wonder why this was reported after so much time.

This changes it to simply class.name. Also adds a list of media
providers found to the warning message.

@theforeman-bot
Copy link
Member

Issues: #30097

tbrisker
tbrisker approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lzap !

@tbrisker tbrisker merged commit dd5e780 into theforeman:develop Jun 11, 2020
@tbrisker
Copy link
Member

tbrisker commented Jun 16, 2020 •
edited
Loading

2.1 - 9f0b726

@lzap lzap deleted the media-provider-error-fix-30097 branch June 16, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzap @theforeman-bot @tbrisker