Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require /lib dependencies in initializers/foreman.rb #8949

Merged
merged 1 commit into from Nov 26, 2021
Merged

Require /lib dependencies in initializers/foreman.rb #8949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 4 additions & 6 deletions config/initializers/foreman.rb
View file
Open in desktop
Expand Up @@ -6,14 +6,12 @@
require_dependency 'foreman/access_permissions'
require_dependency 'foreman/plugin'
require_dependency 'foreman/settings'
require_dependency 'fog_extensions'

# Other internal dependencies, may be autoloaded
require_dependency 'foreman/foreman_url_renderer'
require_dependency 'foreman/controller'
require_dependency 'net'
require_dependency 'foreman/provision' if SETTINGS[:unattended]
require_dependency 'foreman'
require_dependency 'fog_extensions'
require 'foreman/foreman_url_renderer'
require 'net'
require 'foreman/provision' if SETTINGS[:unattended]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe this is even funnier case. It's doing exactly what Zeitwerk will do with a proper inflector setup of (SSH => ssh).
It probably won't work now without it, but we should have a followup task for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://projects.theforeman.org/issues/29991


# in this phase, the classes are not fully loaded yet, load them
Dir[
Expand Down
2 changes: 0 additions & 2 deletions lib/foreman/controller.rb
View file
Open in desktop

This file was deleted.