Fixes #34228 - close bookmarks after selecting a bookmark #9102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #34228 |
Hi, on which pages can I test it? |
|
For example: Audits |
|
[test foreman] |
stejskalleos
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
✔️ LGTM, works as described
There is however an issue with the search field: after selecting the bookmark search field is empty, we should populate the value from the bookmark there. I created special RM#34546 for it.
ezr-ondrej
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Thanks @MariaAga for the fix and thanks @stejskalleos for the review ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After selecting a bookmark some page don't reload and just replace the data so the dropdown should close on select