Fixes #35438 - Unescape cluster on compute resource controller #9452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The webui uses a different controller than hammer does, we don't allow slashes in Apache so this allows nested clusters to be found when using hammer. Also updated various rabl files for better user experience in hammer list commands(seperate pr to that repo) (cherry picked from commit 2bdd197)
|
Issues: #35438 |
chris1984
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
ACK, I don't have merge access so not sure how much my ack counts. @ezr-ondrej can this can an ack? It's a CP
|
Thanks for the ack. I can merge it myself, just waiting for CI now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webui uses a different controller than hammer does, we don't allow slashes in Apache so this allows nested clusters to be found when using hammer. Also updated various rabl files for better user experience in hammer list commands(seperate pr to that repo)
(cherry picked from commit 2bdd197)