Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #3270 - load subnets for the domain associated with each NIC #949

Closed
wants to merge 1 commit into from

Conversation

domcleal
Copy link
Contributor

No description provided.

@ohadlevy
Copy link
Member

@domcleal thanks, would you mind adding a test?

@domcleal
Copy link
Contributor Author

@ohadlevy for the helper itself?

@ohadlevy
Copy link
Member

@domcleal good question, I guess since this is in AJAX, we would need something else then what we currently have, otherwise, we could have done something similar to a functional test with an assert_tag test
e.g.

 assert_tag :tag => 'a', :attributes => { :href => '/roles/1/edit' }

Since its outside of this PR discussion, I'll merge as is.. thanks!

@ohadlevy
Copy link
Member

merged as 2899ab7 thanks @domcleal

@ohadlevy ohadlevy closed this Oct 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants