Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36560 - Persist pxe_loader on os_select #9767

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Fixes #36560 - Persist pxe_loader on os_select #9767

merged 1 commit into from
Jun 30, 2023

Conversation

adamruzicka
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #36280

MariaAga
MariaAga reviewed Jun 30, 2023
View reviewed changes
webpack/assets/javascripts/foreman_hosts.js
@@ -35,6 +35,7 @@ export function getAttributesToPost(componentType) {
'location_id',
'ptable_id',
'medium_id',
'pxe_loader',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this word to .eslintrc

@pnovotny
Copy link

Verified the PR build foreman-3.8.0-0.20230630115616879905.pr9767.8116.gab339257f.el8.noarch on Sat. stream.

When changing the Lifecycle Environment on Host Group tab, the "PXE loader" value on Operating System tab does not reset.

@ofedoren
Copy link
Member

Just a question related to tracking system, can we use Refs on tickets which get into branched/released version? It would seem that this is landed into 3.7.0, but apparently it will land into 3.7.1. Unless I missed dates for GA...

@adamruzicka adamruzicka changed the title Refs #36280 - Persist pxe_loader on os_select Fixes #36560 - Persist pxe_loader on os_select Jun 30, 2023
@adamruzicka
Copy link
Contributor Author

Filed a separate issue, amended the commit message, force pushed, but github seems to be confused

ofedoren
ofedoren approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adamruzicka and @MariaAga, LGTM and fixes the issue. The actual commit message corresponds with the new ticket, all good now.

@ofedoren ofedoren merged commit dee9c60 into theforeman:develop Jun 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariaAga MariaAga MariaAga left review comments

@ofedoren ofedoren ofedoren approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
5 participants
@adamruzicka @theforeman-bot @pnovotny @ofedoren @MariaAga