Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gov-cloud (fixes #96) #97

Merged
merged 1 commit into from Feb 10, 2021
Merged

Conversation

pendor
Copy link
Contributor

@pendor pendor commented Oct 27, 2020

This adds a new preference to select which cloud environment to target.
Endpoint URLs for additonal clouds are taking from MS documentation.
All calls to cloud API's now check the cloud preference and select
the correct endpoint for the current environment.

This adds a new preference to select which cloud environment to target.
Endpoint URLs for additonal clouds are taking from MS documentation.
All calls to cloud API's now check the cloud preference and select
the correct endpoint for the current environment.
@chris1984
Copy link
Member

Starting to Test

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, Works great @pendor

Was able to connect Foreman to the GOV Cloud Compute Resource:

https://1drv.ms/u/s!AmcYeL73Lgj6hltDyFlGbzsujPKv?e=7chTbr

Validated that it would not take a normal Azure account by putting my normal one in it's place

https://1drv.ms/u/s!AmcYeL73Lgj6hybS4EV2s_Q0SDVr?e=WVL4Gv

Was able to create a VM, screenshot showing it building

https://1drv.ms/u/s!AmcYeL73Lgj6hyeO5lpT8tD9vEgx?e=k8FEsf

Finished product in Foreman

https://1drv.ms/u/s!AmcYeL73Lgj6hyjqU-gAFqyemETS?e=Px3j01

Able to list VM's

https://1drv.ms/u/s!AmcYeL73Lgj6hySwqSjAtlG1PWGO?e=qdAGPg

Also tested that it didn't break anything with a normal Azure account and was able to list/build a vm, and delete

@apuntamb can this get a merge, will get my docs pr in and then we can do a new version release.

I am going to demo this Thursday at the Foreman community demo.

Also going to write up the steps needed to go from installing the plugin to getting it working since, I noticed in our upstream/downstream docs we don't talk about that much.

@apuntamb apuntamb merged commit b2dfead into theforeman:master Feb 10, 2021
@apuntamb
Copy link
Member

Thanks for the feature @pendor and @chris1984! 👍
Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants